Closed
Conversation
drahnr
changed the title
Contributor
Author
|
I don't think this works sufficiently well, it always requires applying patches for data types, which makes the entire thing brittle at best. Adding a comment is probably better rather than introducing complexity that will remain incapable addressing the problem fully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #1470
Adds a
make schematarget to regenerate the diesel schema from an existing.Attention
I do not like the approach, since we require a patch file, which is brittle at best for changing schemas.
Alternatives
Consider using a
build.rsbased approach.